Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutter character configuration. #5371

Closed
wants to merge 2 commits into from
Closed

Gutter character configuration. #5371

wants to merge 2 commits into from

Conversation

hadronized
Copy link
Contributor

This commit adds support for configuring the gutter characters. Currently, three flavours are supported:

  • Diagnostics, with a string.
  • Breakpoints, with two strings (one for verified and one for non-verified breakpoints).
  • And diffs, with three strings (add, remove, change).

@the-mikedavis
Copy link
Member

There is some overlap with the gutter configuration here and in #4724 (I would prefer #4724)

@hadronized
Copy link
Contributor Author

Should I rebase on their work and use editor.gutters instead?

@hadronized hadronized mentioned this pull request Jan 3, 2023
Merged
1 task
@kirawi kirawi added A-helix-term Area: Helix term improvements S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 3, 2023
@hadronized
Copy link
Contributor Author

hadronized commented Jan 4, 2023 •
edited
Loading

The new config looks like this, after rebasing on #4724:

image

⚠️ Do not merge before #4724 ⚠️

@hadronized hadronized force-pushed the config/gutter-symbols branch 2 times, most recently from 39918b2 to 33bc160 Compare January 4, 2023 19:20
@hadronized
Copy link
Contributor Author

@kirawi should be okay now, but I guess we have to wait on #4724?

@the-mikedavis the-mikedavis added S-waiting-on-pr Status: This is waiting on another PR to be merged first and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2023
@hadronized
Copy link
Contributor Author

Just rebased to benefit from the upstream changes.

@sudormrfbin
Copy link
Member

There is also overlap with #2869 which is larger in scope; cc @lazytanuki

@hadronized
Copy link
Contributor Author

I’m rebasing my PR tonight. @sudormrfbin I’m not entirely sure how it overlaps, but if it does, what should be the next step? I saw the PR you mentioned is based on several other PRs. Not sure what would change in my PR.

@hadronized
Gutter character configuration.
6b4ce20 
This commit adds support for configuring the gutter characters.
Currently, three flavours are supported:

- Diagnostics, with a string.
- Breakpoints, with two strings (one for verified and one for
  non-verified breakpoints).
- And diffs, with three strings (add, remove, change).
@hadronized
Add configuration doc for gutters characters.
b280008
@hadronized hadronized force-pushed the config/gutter-symbols branch 2 times, most recently from c915294 to b280008 Compare January 23, 2023 20:17
@hadronized
Copy link
Contributor Author

It is rebased and can now be reviewed. Thanks @dgkf for the ping in your PR!

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-pr Status: This is waiting on another PR to be merged first labels Jan 23, 2023
@lazytanuki
Copy link
Contributor

Hi @phaazon. As @sudormrfbin said, your PR overlaps with #2869 which, between other things, allowed the customization of diagnostic and breakpoint symbols. As per @sudormrfbin's request I also implemented the customization of diff symbols as well, so I'm afraid it is now superseeded by #2869.

@hadronized
Copy link
Contributor Author

Okay, I missed that part @lazytanuki. I’m having a look at your PR to see how it works. Thanks for the review!

@hadronized
Copy link
Contributor Author

Alright, should I close the PR? Is #2869 enough for the need solved by my PR (i.e. configuring icons for diff, diagnostics and breakpoints)?

@pascalkuthe pascalkuthe mentioned this pull request Feb 12, 2023
Closed
@hadronized
Copy link
Contributor Author

I’m closing as it’s already implemented in #2869.

@hadronized hadronized closed this Mar 9, 2023
@hadronized hadronized deleted the config/gutter-symbols branch March 9, 2023 22:55
@dead10ck dead10ck mentioned this pull request Apr 15, 2023
Open
15 tasks
@pascalkuthe pascalkuthe mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hadronized @the-mikedavis @sudormrfbin @lazytanuki @kirawi